Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Test custom query #218

Merged
merged 3 commits into from
Sep 5, 2023
Merged

Test custom query #218

merged 3 commits into from
Sep 5, 2023

Conversation

jawoznia
Copy link
Collaborator

@jawoznia jawoznia commented Sep 4, 2023

Add missing custom_query parameter in entry_points macro expansion.

Example with custom module.

@jawoznia jawoznia requested a review from hashedone September 4, 2023 12:42
@jawoznia jawoznia force-pushed the test_custom_query branch 3 times, most recently from 5fef266 to 9ff0e11 Compare September 4, 2023 13:27
@codecov
Copy link

codecov bot commented Sep 4, 2023

Codecov Report

Merging #218 (7c5e41a) into cast_deps_to_empty (1be619e) will decrease coverage by 0.07%.
The diff coverage is 0.00%.

@@                  Coverage Diff                   @@
##           cast_deps_to_empty     #218      +/-   ##
======================================================
- Coverage               87.86%   87.79%   -0.07%     
======================================================
  Files                      24       24              
  Lines                    1302     1303       +1     
======================================================
  Hits                     1144     1144              
- Misses                    158      159       +1     
Files Changed Coverage Δ
sylvia-derive/src/message.rs 83.77% <0.00%> (-0.23%) ⬇️
sylvia-derive/src/parser.rs 84.53% <ø> (ø)
sylvia/tests/custom_msg.rs 100.00% <ø> (ø)

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

Copy link
Collaborator

@hashedone hashedone left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

I was worried that custom modules might be troubling, but it seems it is easy enough to work with them. Ready to merge for me.

examples/contracts/custom/src/multitest/tests.rs Outdated Show resolved Hide resolved
@jawoznia jawoznia merged commit 507cc86 into cast_deps_to_empty Sep 5, 2023
@jawoznia jawoznia deleted the test_custom_query branch September 5, 2023 07:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants